Skip to content

Conversation

@chhoumann
Copy link
Owner

@chhoumann chhoumann commented Feb 1, 2026

Adds a regression test ensuring multiple notes that share the same frontmatter alias are all suggested when typing [[alias in the value input.

This matches Obsidian behavior described in #509.

  • Adds test coverage in src/gui/suggesters/fileSuggester.test.ts
  • bun run test, bun run lint, and bun run build pass locally

Open with Devin

Summary by CodeRabbit

  • Tests
    • Enhanced test coverage to verify correct handling of multiple files sharing identical aliases in search results.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
quickadd Ready Ready Preview Feb 1, 2026 1:19pm

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

📝 Walkthrough

Walkthrough

A new test case is added to the FileSuggester test suite to verify that multiple files sharing identical aliases are correctly returned in search results, exercising the duplicate alias resolution logic.

Changes

Cohort / File(s) Summary
Test Coverage Addition
src/gui/suggesters/fileSuggester.test.ts
Adds test block for Issue #509 covering duplicate alias scenarios, including FileIndex reset, mock file creation with identical aliases, metadataCache mocking, and assertions validating multiple file returns for alias-based searches.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Bouncing through aliases, two files align,
When duplicates match, the search must shine,
Our whiskers twitch with test delight,
Both results returned, both shining bright!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—adding a regression test for duplicate alias suggestions addressing issue #509—and is clear, specific, and concise.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test/issue-509-duplicate-alias-suggestions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: 592e994
Status: ✅  Deploy successful!
Preview URL: https://71d555fa.quickadd.pages.dev
Branch Preview URL: https://test-issue-509-duplicate-ali.quickadd.pages.dev

View logs

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional flags.

Open in Devin Review

@chhoumann chhoumann merged commit 9db2dc4 into master Feb 1, 2026
5 checks passed
@chhoumann chhoumann deleted the test/issue-509-duplicate-alias-suggestions branch February 1, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants