Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Qt5LinguistTools instead of using qtchooser (with linguist tools) #216

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Use Qt5LinguistTools instead of using qtchooser (with linguist tools) #216

merged 2 commits into from
Apr 21, 2017

Conversation

david50407
Copy link
Member

Fixed #203. Fixed #215.

Since we only support Qt5 now, we can use find_package(Qt5LinguistTools) to handle lupdate and lrelease without qtchooser. This could fix #203, and this must fix #215, too.

@david50407 david50407 changed the title Use Qt5LinguistTools instead of using qtchooser (with liguist tools) Use Qt5LinguistTools instead of using qtchooser (with linguist tools) Apr 13, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling 90d4548 on david50407:fix/qtchooser into 1679266 on chewing:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling a35479c on david50407:fix/qtchooser into 1679266 on chewing:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling 7cad835 on david50407:fix/qtchooser into 1679266 on chewing:master.

@david50407
Copy link
Member Author

@czchen I removed qtchooser from dependnecy and use Qt5LinguistTools cmake module to find Linguist tools (in Ubuntu, install qttools5-dev to get the cmake module). Can you help me to test on your development environment? Thank you 😄

@david50407 david50407 requested a review from czchen April 17, 2017 07:58
@david50407
Copy link
Member Author

Because there are other PRs pending due to this fix, I'm going to merge this first.

@david50407 david50407 merged commit b32701c into chewing:master Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czchen czchen Awaiting requested review from czchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSX CI build fails No qtchooser on OS X with homebrew for cmake
2 participants
@david50407 @coveralls