Feature/#61: Support GC log file rotation #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementation Different kind of GcResources may exist that should be treated uniformly. This allows to have "real" file backed GcResources as well as artificially assembled ones that are backed by more than one file. If required, other subclasses can be created for GcResources that are not backed by any file at all.
For several model elements a proper #equals & hashcode have been added. This allows to compare GCEvents & GCModels, e.g. in tests. This should however also come in handy in other situations, e.g when storing them in hash based collections
In cases where the creation date is unavailable (URL resource, unix filestystem) the lastModified time is used instead.
Support for rotated logfiles has been added. This allows to open a series of consecutive logfiles and treat them as one (merged) gc log. This allows to analyze logfiles that have been created over a longer period in a production environment.
…ewiebug#61) When a series of logfiles was recently opened, it can now be reopened from the "recent" menu. In order to support this, GCResourceGroup was refactored and now only stores the URL of a Resource instead of the whole resource (as it apparently was already before). This allows to also store GcResourceSeries in the same way as regular GcResources.
Commandline support for parsing logfile series has been added. Syntactically this is close to existing commandline arguments. Some additional refactoring was done to have a unified handling of the various types of resources that can be used.
- In the "recent" menu, show shortened description for GcSeries - Added calculation of start date to GCModel - Fixed error when loading a GcSeries via Commandline - Other smaller improvements
|
Thank you very much - I will merge it soon! |
|
Looking forward to it. |
|
No, you can leave the conflict resolution to me - there seems to be an issue with my latest addition to the ibm j9 parser. It shouldn't be too hard to merge.
I prefer to add the performance improvement as a separate pull request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for rolled GC log files (called "series") has been added.
The underlying model was extended in order to support this efficiently.
See related issue for more details.