fix: bestmove output gets sometimes split on 2 lines #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomsons
changed the title
Author
|
@pdil ? |
Amir-Zucker
reviewed
Dec 2, 2025
| /// Engines work asynchronously so use this block to subscribe to | ||
| /// any commands received from the engine. | ||
| @property (nullable) void (^ responseHandler)(NSString * _Nonnull response); | ||
| @property (nonatomic, strong) NSMutableString *outputBuffer; |
Contributor
There was a problem hiding this comment.
I think this could be an ivar like the pipes/file handles/lock/engine or a property inside a class extension inside EngineMessenger.mm, no reason to expose it outside of EngineMessenger class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation sometimes splits the bestmove response on 2 lines, this is related to the fact that the output can be chunked arbitrarily, especially when using NSFileHandle in async mode.
This fix ensures that every line entirely parsed once ready