CSS Fixes #145
Open
CSS Fixes #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make a local "db/development" database, but rather a global, across your whole system DB with the name "db/development." So make the defaults more obviously tied to this app.
I am Zion teehee
So I added some colors for the error and notice module. I created an inner-container, although I saw that maybe Bulma or steph already had some classes for inner-container? Aside from that added .text-center class as a helper. Also added .button-close with its respective styling for each type of container. ( Error or Notice )
cheshire137
approved these changes
Dec 23, 2017
| } | ||
|
|
||
| render() { | ||
| const { message, type } = this. props |
There was a problem hiding this comment.
You have a stray space after this.. 👀
| } | ||
| } | ||
|
|
||
| //Display this crazy stuff |
| className="button-close" | ||
| type="button" | ||
| onClick={() => this.toggle()} | ||
| >╳</button> |
|
|
||
| .inner-container { | ||
| @extend .container; | ||
| width: 1110px; |
There was a problem hiding this comment.
Should this be in a media query? Actually I don't know if the app has a responsive layout right now, so maybe it doesn't matter. 🤔
|
Looks like the linter caught you: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm back!
I've added some quick css fixes and the notification changes. Notifications is still not done? I think, don't remember if I did a PR or not.