Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /plugins/ returns both installed and available plugins #387

Merged
merged 9 commits into from
Aug 8, 2023
Merged

GET /plugins/ returns both installed and available plugins #387

merged 9 commits into from
Aug 8, 2023

Conversation

valentimarco
Copy link
Collaborator

Description

2 new function to retrieve from registry all external plugins available and to install plugins by url.

For now the implementation of "retrieve from registry" bricks plugin page on admin!

Related to issue #300

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

core/cat/routes/plugins.py Outdated Show resolved Hide resolved
core/cat/routes/plugins.py Outdated Show resolved Hide resolved
core/cat/routes/plugins.py Outdated Show resolved Hide resolved
core/cat/routes/plugins.py Outdated Show resolved Hide resolved
core/cat/routes/plugins.py Outdated Show resolved Hide resolved
# Conflicts:
#	core/cat/routes/plugins.py
@pieroit
Copy link
Member

pieroit commented Aug 4, 2023

Why closed? Just put the PR as a draft until you finish :)

@valentimarco
Copy link
Collaborator Author

i didn't nothing, i synced the fork. Maybe that?

@pieroit
Copy link
Member

pieroit commented Aug 4, 2023

I see zero commits on the PR
Let me know, you can reopen this or create a new one

@valentimarco valentimarco reopened this Aug 4, 2023
@valentimarco
Copy link
Collaborator Author

I see zero commits on the PR Let me know, you can reopen this or create a new one

Re open the PR

@valentimarco valentimarco reopened this Aug 4, 2023
@pieroit pieroit merged commit 44b3f6e into cheshire-cat-ai:develop Aug 8, 2023
2 checks passed
@pieroit
Copy link
Member

pieroit commented Aug 8, 2023

Thanks @valentimarco congrats on your merged PR :D

Let's wait a little before testing this code because the responsibility of finding and caching the .zip file of plugins may rest on this repo.

Let's discuss this further with @EugenioPetulla @nicola-corbellini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants