Skip to content

Conversation

MichaIng
Copy link
Contributor

@MichaIng MichaIng commented Jan 10, 2022

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

e1a45fa

❓ What is the current behavior? (You can also link to an open issue here)

❓ What is the new behavior (if this is a feature change)?

πŸ“‹ Other information:

The significant idle CPU load reduction is especially present on
non-Windows systems, having up to 100 connection handler loops per
second reduced to ~2 loops/s by default, while on Windows it is less
significant with a reduction to ~20 loops/s and with a theoretically
reduced performance when quickly repeating requests.

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

The significant idle CPU load reduction is especially present on
non-Windows systems, having up to 100 connection handler loops per
second reduced to ~2 loops/s by default, while on Windows it is less
significant with a reduction to ~20 loops/s and with a theoretically
reduced performance when quickly repeating requests.

Signed-off-by: MichaIng <micha@dietpi.com>
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #466 (7a2e25c) into master (30c91c1) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   80.22%   79.90%   -0.32%     
==========================================
  Files          28       28              
  Lines        4395     4395              
==========================================
- Hits         3526     3512      -14     
- Misses        869      883      +14     

@MichaIng
Copy link
Contributor Author

MichaIng commented Jan 10, 2022

As the commit message check fails for forks, here the result run on my fork: https://github.com/MichaIng/cheroot/runs/4765273291

Conformance to the 7 rules of a great Git commit message:
[PASSED] Separate subject from body with a blank line
[PASSED] Limit the subject line to 50 characters
[PASSED] Capitalize the subject line
[PASSED] Do not end the subject line with a period
[PASSED] Use the imperative mood in the subject line
[PASSED] Wrap the body at 72 characters
[ NA ] Use the body to explain what and why vs. how

@webknjaz
Copy link
Member

Thanks!

@webknjaz webknjaz merged commit 4b62bab into cherrypy:master Jan 12, 2022
@MichaIng MichaIng deleted the changelog-fix-description branch January 12, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants