Skip to content

Conversation

@el-besto
Copy link

@el-besto el-besto commented Feb 5, 2024

In strict mode variables must be properly declared. There is a portion in the tempa-xlsx package which declares the QUOTE variable incorrectly as var APOS = "'"; QUOTE = '"'.

This PR uses patch-package to fix the issue so that:

var APOS = "'"; QUOTE = '"'

becomes:

var APOS = "'", QUOTE = '"'

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: dfaa91e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@el-besto el-besto merged commit 4cf2016 into master Feb 5, 2024
@el-besto el-besto deleted the fix/patch-xlsx-dependency branch February 5, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants