Feature/user profile #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
May 29, 2025 01:02
cherkasovaa
approved these changes
Jun 2, 2025
Comment on lines
+1
to
+29
| import type { TextFieldConfig } from './types'; | ||
|
|
||
| export const TEXT_FIELDS: TextFieldConfig[] = [ | ||
| { key: 'firstName', label: 'First Name' }, | ||
| { key: 'lastName', label: 'Last Name' }, | ||
| { key: 'email', label: 'Email' }, | ||
| { key: 'password', label: 'Password', type: 'password' }, | ||
| ]; | ||
|
|
||
| export const ERROR_MESSAGES = { | ||
| REQUIRED: 'This field is required', | ||
| FIRST_NAME_REQUIRED: 'First name is required', | ||
| LAST_NAME_REQUIRED: 'Last name is required', | ||
| EMAIL_REQUIRED: 'Email is required', | ||
| PASSWORD_REQUIRED: 'Password is required', | ||
| BIRTH_DATE_REQUIRED: 'Date of birth is required', | ||
| SHIPPING_ADDRESS_REQUIRED: 'Please select a default shipping address', | ||
| BILLING_ADDRESS_REQUIRED: 'Please select a default billing address', | ||
|
|
||
| LETTERS_ONLY: 'Only letters allowed', | ||
| INVALID_EMAIL: 'Enter correct email', | ||
| INVALID_PASSWORD: | ||
| 'Minimum 8 characters, at least 1 uppercase letter, 1 lowercase letter, and 1 number', | ||
| AGE_RESTRICTION: 'You must be older than 13 years old', | ||
| INVALID_SHIPPING_ADDRESS: 'Invalid default shipping address', | ||
| INVALID_BILLING_ADDRESS: 'Invalid default billing address', | ||
| }; | ||
|
|
||
| export const MIN_AGE = 13; |
Owner
There was a problem hiding this comment.
Это круто, что ты выносишь в переменные тексты 👍
| const loginWithCommercetools = async (credentials: ILoginFormProps) => { | ||
| try { | ||
| await switchToPasswordFlow(credentials.email, credentials.password); | ||
| //NEED REFACTOR |
Owner
There was a problem hiding this comment.
есть плагины для VSCode Todo Tree или Better Comments. Для подобных комментариев 🔥
| }) => { | ||
| //PUT TO SHARED | ||
| const formatDate = (dateString: string) => { | ||
| return new Date(dateString).toLocaleDateString('en-US', { |
Owner
There was a problem hiding this comment.
язык лучше было вынести в константу
| window.addEventListener('authStatusChanged', () => { | ||
| const isAuth = localStorageService.getAuthStatus(); | ||
| if (!isAuth) navigate('/'); | ||
| if (!isAuth) navigate('/login'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left some comments for refactoring and improving code, please leave it after merge