Catalog Page Implementation #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange text for no products
…ok for all catalog params, small fixed
cherkasovaa
approved these changes
May 31, 2025
| label="Sort By" | ||
| onChange={(e) => onChange(e.target.value)} | ||
| > | ||
| <MenuItem value="name[en-US] asc">Alphabetically, A-Z</MenuItem> |
Owner
There was a problem hiding this comment.
[en-US] - язык в приложении часто используется. Лучше хранить это в переменной
| position: 'absolute', | ||
| inset: 0, | ||
| backgroundImage: `url(${imageUrl})`, | ||
| backgroundImage: `url(https://images.unsplash.com/photo-1664448288134-669f14c3ebbb?q=80&w=2080&auto=format&fit=crop&ixlib=rb-4.1.0&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D)`, |
Owner
There was a problem hiding this comment.
почему бы не вынести этот урл в константу куда нибудь?
aissatsana
approved these changes
Jun 2, 2025
Collaborator
aissatsana
left a comment
aissatsana
left a comment
There was a problem hiding this comment.
Может я просмотрела, но кажется при запросах не хватает обработки ошибок
| import { type Category } from '@commercetools/platform-sdk'; | ||
| import { useCategories } from './useCategories'; | ||
|
|
||
| export const useDefaultCategoryId = (): Category | undefined => { |
Collaborator
There was a problem hiding this comment.
Наверное лучше согласовать функцию по названию файла, и использовать нейминг use для хуков
|
|
||
| const image = product.masterVariant.images?.[0]?.url ?? undefined; | ||
| const placeholder = | ||
| 'https://upload.wikimedia.org/wikipedia/commons/1/14/No_Image_Available.jpg'; |
Collaborator
There was a problem hiding this comment.
Лучше закинуть в проект картинку, не использовать сторонние адреса без необходимости
| [tags] | ||
| ); | ||
|
|
||
| React.useEffect(() => { |
Collaborator
There was a problem hiding this comment.
для читаемости и чистоты лучше импортировать сразу хук и обращаться к нему без React (и в других файлах тоже)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: link
Screenshot:
Deploy: link
Done 30.05.2025 / deadline 03.06.2025
Score: 100 / 100
Tasks:
4.1 Display Product List (45 points) 📋
4.2 Product Filtering, Sorting, and Searching (65 points) 🔍
4.3 Interactive Product Cards (15 points) 🃏
4.4 Category Navigation (25 points) 🧭
4.5 Tests