Open
Conversation
xxxzerone
reviewed
Jun 3, 2024
Comment on lines
+12
to
+15
| Computer computer = new Computer(); | ||
| Player player = new Player(); | ||
| Judge judge = new Judge(); | ||
| Playagain playagain = new Playagain(); |
| private int strike; | ||
|
|
||
|
|
||
| public Count(List<Integer> player, List<Integer> computer) { |
There was a problem hiding this comment.
Player, Computer로 파라미터를 받았으면 의사표현이 더 잘될것 같아요
| List<Integer> computers = computer.numlist(); | ||
| String result = ""; | ||
| while (!result.equals("3스트라이크")){ | ||
| result = judge.judge(player.insert(),computers); |
There was a problem hiding this comment.
judge.judge(), playagain.playagain() 내용이 겹쳐서 judge.기능명()으로 표현하는건 어떨까요?
| List<Integer> list = new ArrayList<>(); | ||
| boolean current = true; | ||
| // while(current){ | ||
| for (char c : input.toCharArray()) { |
Songj2
reviewed
Jun 4, 2024
| } | ||
|
|
||
|
|
||
| public List<Integer> insert() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
숫자 야구 게임