Skip to content

feat: support whittaker, cubic, and bernstein baseline algorithms#4008

Draft
hamed-musallam wants to merge 2 commits intomainfrom
support-new-baseline-methods
Draft

feat: support whittaker, cubic, and bernstein baseline algorithms#4008
hamed-musallam wants to merge 2 commits intomainfrom
support-new-baseline-methods

Conversation

@hamed-musallam
Copy link
Member

  • whittaker options: lambda, scale, maxIterations
  • cubic: no options
  • bernstein options: maxIterations, tolerance, factorStd, learningRate, minWeight

close #3969

- whittaker options: lambda, scale, maxIterations
- cubic: no options
- bernstein options: maxIterations, tolerance, factorStd, learningRate, minWeight

close  #3969
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 25, 2026

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e37a1d
Status: ✅  Deploy successful!
Preview URL: https://05a9c984.nmrium.pages.dev
Branch Preview URL: https://support-new-baseline-methods.nmrium.pages.dev

View logs

@hamed-musallam
Copy link
Member Author

@lpatiny @jobo322

The new baseline correction filter options do not have enough room in the NMRium header. Which options are important to stay there? , FYI, all options will exist in the processing panel as well.

image image

@jobo322
The 'bernstein' crashes when tested. Could you have a look?

image

@hamed-musallam
Copy link
Member Author

@jobo322

Are there any constraints on the min and max values for each option?

@targos
Copy link
Member

targos commented Feb 27, 2026

@hamed-musallam

The 'bernstein' crashes when tested. Could you have a look?

degree is a mandatory option in the Bernstein algorithm:
CleanShot 2026-02-27 at 10 20 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for 3 new baseline methods available in baseline filter

2 participants