Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ride of np.bool deprecation warning. #155

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Get ride of np.bool deprecation warning. #155

merged 2 commits into from
Dec 23, 2022

Conversation

alexlitz
Copy link
Contributor

Missed another DeprecationWarning with the last one.

@cheind
Copy link
Owner

cheind commented Feb 23, 2022

@alexlitz did you see my code comment about public API concern?

@alexlitz
Copy link
Contributor Author

@cheind no, I do not see a comment about that.

@cheind
Copy link
Owner

cheind commented Feb 26, 2022

Here https://github.com/cheind/py-motmetrics/pull/155/files/fc06cd2e66c57250d1322457b59a52232c951ee4

@facundo-lezama facundo-lezama mentioned this pull request Dec 23, 2022
Closed
@facundo-lezama
Copy link

@cheind @alexlitz Please see issue #172, I believe merging this PR is pretty urgent.

@cheind
Copy link
Owner

cheind commented Dec 23, 2022

@facundo-lezama thanks for pointing this out!

@cheind
Copy link
Owner

cheind commented Dec 23, 2022

I've found that bool_ is part of the public API here
https://numpy.org/doc/stable/user/basics.types.html

So I will merge this to develop.

@cheind cheind merged commit fa288b6 into cheind:develop Dec 23, 2022
@facundo-lezama facundo-lezama mentioned this pull request Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlitz @cheind @facundo-lezama