Skip to content

Commit

Permalink
chore(aws-cdk-lib): revert raising the min node version to v14 (aws#1…
Browse files Browse the repository at this point in the history
…2704)

This reverts commit 4aa64c8

This change is incompatible with our build image 'jsii/superchain' that
has node v10 as its requirement. We would still like the default version
of this build image to stay at v10 since that is the minimum supported
version of CDKv1.

Additional work is required in this area before we can raise the node
version requirement for this package. Reverting now so we don't have
a blocked pipeline.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
Niranjan Jayakar authored Jan 26, 2021
1 parent 70f6403 commit 532c91f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion .yarnrc
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
--install.check-files true # install will verify file tree of packages for consistency
ignore-engines true # the 'engines' key for 'aws-cdk-lib' has specifies node14 as min while v1 will remain at node10
6 changes: 1 addition & 5 deletions tools/pkglint/lib/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1070,11 +1070,7 @@ export class MustHaveNodeEnginesDeclaration extends ValidationRule {
public readonly name = 'package-info/engines';

public validate(pkg: PackageJson): void {
if (cdkMajorVersion() === 2) {
expectJSON(this.name, pkg, 'engines.node', '>= 14.15.0');
} else {
expectJSON(this.name, pkg, 'engines.node', '>= 10.13.0 <13 || >=13.7.0');
}
expectJSON(this.name, pkg, 'engines.node', '>= 10.13.0 <13 || >=13.7.0');
}
}

Expand Down

0 comments on commit 532c91f

Please sign in to comment.