Avoid global mutation. #852
Conversation
| @@ -82,6 +83,10 @@ class Plugin | |||
| include Ohai::Mixin::Command | |||
| include Ohai::Mixin::SecondsToHuman | |||
|
|
|||
| # Pending next major release of Ohai. | |||
There was a problem hiding this comment.
Removal pending? The comment is a bit vague. Also when we leave comments in code that say next major version no action is ever taken. Pick the version where we plan to deprecate it.
There was a problem hiding this comment.
We should probably decide first if we want it to be removed at all or if FileHelper should just stay as part of the Plugin base API. That would seem fine too :)
There was a problem hiding this comment.
I'd be fine if we kept this part of the Plugin base API. It's small and useful for writing plugins.
There was a problem hiding this comment.
Roger, updating PR :)
… small, doesn't stomp on much, and is helpful in a large number of plugins.
|
The DmiDecode change might break something but it seems much less likely someone was accidentally using those methods :) Will see what the tests say. |
|
I highly doubt anyone is using the DMI helper and it's the right thing to do. Lets just fix that. |
|
+1 Thanks for noticing this @coderanger |
Closes #851.