Language plugins: Improve failure logging, update specs, general cleanup #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcquin & @chef/client-core This is ready for review |
…e sample output in code
| languages[:go] = go if go[:version] | ||
| end | ||
| begin | ||
| so = shell_out("go version") |
There was a problem hiding this comment.
(minor) Indenting too deep.
|
Looks good. Some minor feedback for style and consistency. Looks like the appveyor failure is incorrect, all specs passed. |
|
🚀 |
| so = shell_out("go version") | ||
| # Sample output: | ||
| # go version go1.6.1 darwin/amd64 | ||
| if so.exitstatus == 0 |
There was a problem hiding this comment.
these two ifs should be combined.
There was a problem hiding this comment.
there's a bunch, but yeah I can fix those
|
some nits but 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a big change, but it's basically the same thing over and over again for each plugin