Don't execute .so libs for Windows #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
why on earth are we even doing this on unix? but 👍 yeah, definitely... what a bizzare API... i guess it solves the problem of finding out your glibc version without needing to know about your package management tools in a way which is at least portable across linuxes... |
|
👍 |
|
For historical reference - http://unix.stackexchange.com/questions/61646/why-are-so-files-executable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where evaluating the C plug-in causes Windows to issue spurious DNS calls because the file path can get evaluated as a UNC in some cases. We should not be trying to shell out and execute .so files in a non-Unix environment.
@chef/client-core