Use escape_glob_dir instead of escape_glob #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ruby >= 2.2, Dir.glob behaves differently than ruby 2.0 and breaks in more places when backslashes are used when globbing. This means that Windows is sad and will not load any plugins with Ruby >= 2.2 in a lot of cases. This is the safest thing to do because it will use forward slashes.
jaym
force-pushed
the
jdm/escape-dir-glob
branch
from
994b1e6
to
4ea42b7
Compare
|
👍 |
1 similar comment
|
👍 |
thommay
added a commit
that referenced
this pull request
Mar 7, 2016
Use escape_glob_dir instead of escape_glob
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ruby >= 2.2, Dir.glob behaves differently than ruby 2.0
and breaks in more places when backslashes are used when globbing.
This means that Windows is sad and will not load any plugins with
Ruby >= 2.2 in a lot of cases. This is the safest thing to do
because it will use forward slashes.