chef-client stop init.d service stopping other process fixes #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
tas50
reviewed
Oct 29, 2020
| @@ -43,6 +43,8 @@ start() { | |||
|
|
|||
| stop() { | |||
| echo -n $"Stopping $prog: " | |||
| # It will pick the process id directly from the running process and adding into $pidfile. | |||
| ps -ef |grep $exec |grep -v grep |awk '{print $2}' > $pidfile | |||
There was a problem hiding this comment.
Has this been tested to confirm this works? -p is for a pidfile. Does it work if you stick a PID in there instead of a path?
There was a problem hiding this comment.
@tas50 Yes it has been tested working fine. It won't work if we stick PID in there because killproc does not having that type of functionality. In killproc function there are mentioned that if you are mentioning -p then you have to give pidfile not pid.
|
This seems like it really kills the whole point of the assigned pidfile, but I guess that's the kind of thing we have to do for RHEL 6 which thankfully is EOL at the end of this month. This whole fix doesn't live for long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: antima-gupta agupta@msystechnologies.com
Description
Issues Resolved
#221
#718
Check List