Correct bug in implementation of Cheerio#val
#544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery does not attempt to calculate the value of a `radio` input group. Instead, when the value of such an element is queries, that element's `value` attribute is returned directly. Although slightly less convenient in some cases, this allows for direct manipulation of `radio` input element values (which is otherwise impossible).
|
How differs the current behavior to jQuery in a browser? What problem do you want to solve? |
|
Currently, Cheerio attempts to find the group that the selected The problem I want to solve is parity with jQuery. jQuery's implementation is more useful because it allows you to get/set the value of elements that are not currently "checked" (this is impossible with Cheerio today). |
|
Okay, yeah. LGTM |
fb55
added a commit
that referenced
this pull request
Dec 25, 2014
Correct bug in implementation of `Cheerio#val`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery does not attempt to calculate the value of a
radioinput group.Instead, when the value of such an element is queries, that element's
valueattribute is returned directly.Although slightly less convenient in some cases, this allows for direct
manipulation of
radioinput element values (which is otherwiseimpossible).