Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.html() send context to parse5 #1627

Merged
merged 2 commits into from
Jan 1, 2021
Merged

.html() send context to parse5 #1627

merged 2 commits into from
Jan 1, 2021

Conversation

5saviahv
Copy link
Contributor

@5saviahv 5saviahv commented Jan 1, 2021

using proper context when parsing in .html()

It solves #1083

@5saviahv 5saviahv added the javascript Pull requests that update Javascript code label Jan 1, 2021
@fb55 fb55 merged commit bf04330 into cheeriojs:main Jan 1, 2021
@fb55
Copy link
Member

fb55 commented Jan 1, 2021

Great job @5saviahv!

@5saviahv 5saviahv deleted the parse5-context branch January 1, 2021 18:23
@bodinsamuel
Copy link

Hello, this seems to break when used in combinaison with _useHtmlParser2
I know htmlParser2 is somewhat hidden so, is it fixable or is it expected/won't fix? ☺️

https://runkit.com/embed/kv9cok8uese9

@5saviahv
Copy link
Contributor Author

hmm, it seems to be my mistake/typo

@bodinsamuel
Copy link

Thanks @5saviahv 🙏🏻

@bodinsamuel bodinsamuel mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@5saviahv @fb55 @bodinsamuel