fix(types): Fix AttrFunction arguments (#1669)

* fix(typing): AttrFunction * test(types): AttrFunction * chore(lint): AttrFunction prettier
cheeriojs · Jan 12, 2021 · 5f2e9c3 · 5f2e9c3
1 parent a336301
commit 5f2e9c3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -2,7 +2,7 @@ import { Document, Element, DomHandlerOptions } from 'domhandler';
 import { ParserOptions } from 'htmlparser2';
 
 declare namespace cheerio {
-  type AttrFunction = (el: Element, i: number, currentValue: string) => any;
+  type AttrFunction = (this: Element, i: number, currentValue: string) => any;
 
   interface Cheerio {
     // Document References

diff --git a/types/index.test-d.ts b/types/index.test-d.ts
@@ -81,8 +81,16 @@ $el.cheerio;
 $el.attr();
 $el.attr('id');
 $el.attr('id', 'favorite').html();
-$el.attr('id', (el, i, attr) => el.tagName + i * 2 + attr).html();
-$el.attr('id', (el) => el.tagName).html();
+$el
+  .attr('id', function (i, attr) {
+    return this.tagName + i * 2 + attr;
+  })
+  .html();
+$el
+  .attr('id', function () {
+    return this.tagName;
+  })
+  .html();
 $el.attr({ id: 'uniq', class: 'big' }).html();
 
 $multiEl.prop('foo') === undefined;