Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacings fixes #14

Merged

Conversation

rene-ye
Copy link

@rene-ye rene-ye commented Jul 9, 2018

cleaner code & logic

cleaner code & logic
@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #14 into hashKeyChanges will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             hashKeyChanges      #14      +/-   ##
====================================================
- Coverage             48.56%   48.51%   -0.05%     
+ Complexity             2774     2771       -3     
====================================================
  Files                   116      116              
  Lines                 27349    27342       -7     
  Branches               4563     4562       -1     
====================================================
- Hits                  13283    13266      -17     
- Misses                11899    11913      +14     
+ Partials               2167     2163       -4
Flag Coverage Δ Complexity Δ
#JDBC42 48.05% <100%> (-0.06%) 2730 <2> (-1)
#JDBC43 48.43% <100%> (-0.01%) 2764 <2> (-2)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.79% <100%> (-0.14%) 334 <2> (-1)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75% <0%> (-1.57%) 30% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.74% <0%> (-0.68%) 106% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.06% <0%> (-0.3%) 0% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.55% <0%> (-0.21%) 64% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.17% <0%> (-0.07%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 53.23% <0%> (+0.06%) 262% <0%> (+1%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.86%) 43% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27da9e2...d349ff5. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit b442832 into cheenamalhotra:hashKeyChanges Jul 9, 2018
cheenamalhotra pushed a commit that referenced this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants