Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving driver specific functions #10

Merged
merged 7 commits into from
Jun 13, 2018

Conversation

rene-ye
Copy link

@rene-ye rene-ye commented Jun 12, 2018

for SQLServerPreparedStatement. Looking into why we need so many repetitive functions.

for SQLServerPreparedStatement
@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #10 into compliance_42 will decrease coverage by 0.09%.
The diff coverage is 12.5%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             compliance_42      #10     +/-   ##
==================================================
- Coverage            48.42%   48.32%   -0.1%     
+ Complexity            2607     2605      -2     
==================================================
  Files                  108      109      +1     
  Lines                26524    26527      +3     
  Branches              4448     4448             
==================================================
- Hits                 12843    12818     -25     
- Misses               11523    11560     +37     
+ Partials              2158     2149      -9
Flag Coverage Δ Complexity Δ
#JDBC42 47.74% <12.5%> (-0.17%) 2556 <2> (-3)
#JDBC43 48.27% <12.5%> (-0.08%) 2602 <2> (-4)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.19% <0%> (ø) 66 <1> (ø) ⬇️
...microsoft/sqlserver/jdbc/ISQLServerConnection.java 0% <0%> (ø) 0 <0> (?)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.12% <50%> (-0.04%) 322 <1> (+1)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-2.25%) 16% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 43.4% <0%> (-2.02%) 106% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.84% <0%> (-0.63%) 63% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.49% <0%> (-0.36%) 244% <0%> (-3%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.28% <0%> (-0.25%) 161% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (-0.12%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.15% <0%> (-0.04%) 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16001c6...8aa4a5a. Read the comment docs.

repeptitive delcarations

public int getPreparedStatementHandle() throws SQLServerException;

public void setBigDecimal(int n,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add JavaDocs wherever applicable.

there are problems with moving all Driver sepcific public methods. SQLServerConnectionPoolProxy also implements this interface and there are many public APIs (such as preparedstmt cacheing stuff) which it doesn't implement, and cannot be moved into the interface at this time.
should generally stick to 1 line if possible.
@cheenamalhotra cheenamalhotra merged commit 318be65 into cheenamalhotra:compliance_42 Jun 13, 2018
@rene-ye rene-ye deleted the compliance_42 branch October 10, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants