-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving driver specific functions #10
moving driver specific functions #10
Conversation
for SQLServerPreparedStatement
Codecov Report
@@ Coverage Diff @@
## compliance_42 #10 +/- ##
==================================================
- Coverage 48.42% 48.32% -0.1%
+ Complexity 2607 2605 -2
==================================================
Files 108 109 +1
Lines 26524 26527 +3
Branches 4448 4448
==================================================
- Hits 12843 12818 -25
- Misses 11523 11560 +37
+ Partials 2158 2149 -9
Continue to review full report at Codecov.
|
repeptitive delcarations
|
||
public int getPreparedStatementHandle() throws SQLServerException; | ||
|
||
public void setBigDecimal(int n, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add JavaDocs wherever applicable.
there are problems with moving all Driver sepcific public methods. SQLServerConnectionPoolProxy also implements this interface and there are many public APIs (such as preparedstmt cacheing stuff) which it doesn't implement, and cannot be moved into the interface at this time.
…ql-jdbc into compliance_42
should generally stick to 1 line if possible.
for SQLServerPreparedStatement. Looking into why we need so many repetitive functions.