Skip to content

wrong-modification to get kinesis shards #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wrong-modification to get kinesis shards #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/com/aws/Helper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ static JSONObject getJsonObject(String message) {
static List<Shard> getOpenShards(DescribeStreamRequest describeStreamRequestWithExclusiveShardStart,
String exclusiveStartShardId, AmazonKinesis kinesis) {
List<Shard> shards = new ArrayList<>();
do {
/*do {
describeStreamRequestWithExclusiveShardStart.setExclusiveStartShardId(exclusiveStartShardId);
DescribeStreamResult describeStreamResult = kinesis.describeStream(describeStreamRequestWithExclusiveShardStart);
shards.addAll(describeStreamResult.getStreamDescription().getShards());
Expand All @@ -99,8 +99,9 @@ static List<Shard> getOpenShards(DescribeStreamRequest describeStreamRequestWith
exclusiveStartShardId = null;
}

}while (exclusiveStartShardId != null);

}while (exclusiveStartShardId != null);*/
DescribeStreamResult describeStreamResult = kinesis.describeStream(describeStreamRequestWithExclusiveShardStart);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation generated by Amazon CodeGuru Reviewer

This code might not produce accurate results if the operation returns paginated results instead of all results. Consider adding another call to check for additional results.

shards.addAll(describeStreamResult.getStreamDescription().getShards());
return shards;
}

Expand Down