Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 3 of moving off oclif to vanilla CLI #900

Merged
merged 26 commits into from
Mar 29, 2021
Merged

Part 3 of moving off oclif to vanilla CLI #900

merged 26 commits into from
Mar 29, 2021

Conversation

scalvert
Copy link
Contributor

This one is a big one...

This is the port of oclif to vanilla CLI by implementing the following:

  1. A new CLI via yargs - checkup run ...
  2. A new Node API implemented in the CheckupTaskRunner class, which encapsulates the functionality that was previously in the RunCommand
  3. Extensive updates to the generators such that we now utilize the generators for generating plugin and task test fixtures. This provides a powerful capability of ensuring that the JavaScript generated files are still functional, while our existing plugins test the TypeScript code paths
  4. Tests have been changed to use execa to execute the bin script directly, while the node API tests allow us to test the API directly, without the expensive overhead of creating fixtures and executing via execa.

This PR may have a few changes along the way, but I wanted to get it out there for folks to start commenting on.

@scalvert scalvert requested review from carakessler and rwjblue March 22, 2021 15:52
@scalvert scalvert added this to the v1.0.0 milestone Mar 22, 2021
Copy link
Collaborator

@carakessler carakessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory review looks good, just a few questions!

@scalvert
Copy link
Contributor Author

@carakessler @rwjblue since this is largely a PR that we've collectively discussed/worked on together, and in the interest of moving forward with the broad changes targeted for v1.0.0, I'm going to merge this in. We can absolutely address/revisit anything we want to change later.

@scalvert scalvert merged commit 818d9e2 into master Mar 29, 2021
@scalvert scalvert deleted the remove-oclif-3 branch March 29, 2021 20:08
This was referenced Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants