-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 3 of moving off oclif to vanilla CLI #900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursory review looks good, just a few questions!
2bba9a9
to
78748db
Compare
4978fbc
to
0d19bbb
Compare
@carakessler @rwjblue since this is largely a PR that we've collectively discussed/worked on together, and in the interest of moving forward with the broad changes targeted for v1.0.0, I'm going to merge this in. We can absolutely address/revisit anything we want to change later. |
This one is a big one...
This is the port of oclif to vanilla CLI by implementing the following:
checkup run ...
CheckupTaskRunner
class, which encapsulates the functionality that was previously in theRunCommand
This PR may have a few changes along the way, but I wanted to get it out there for folks to start commenting on.