Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plugin-ember-octane #83

Merged
merged 13 commits into from
Mar 5, 2020
Merged

Create plugin-ember-octane #83

merged 13 commits into from
Mar 5, 2020

Conversation

lbdm44
Copy link

@lbdm44 lbdm44 commented Mar 5, 2020

This is not fully functional, since there is a lot of moving parts, we are checking this in and refactoring with smaller PRs going forward.

@lbdm44 lbdm44 changed the title Plugin Ember Octane feat(plugin-ember-octane): Create plugin-ember-octane Mar 5, 2020
@lbdm44 lbdm44 added checkup-task Changes scoped to a specific task/set of tasks enhancement New feature or request labels Mar 5, 2020
Copy link
Contributor

@scalvert scalvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good, Lewis!

legacyDecorators: true,
},
},
plugins: ['ember'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very sensible to me, in that we can tie the specific ruleset directly with the task. I'm 👍 on this.

@lbdm44 lbdm44 merged commit f3c9e5f into master Mar 5, 2020
@lbdm44 lbdm44 deleted the lbdm44/plugin-ember-octane branch March 5, 2020 21:02
@lbdm44 lbdm44 restored the lbdm44/plugin-ember-octane branch March 5, 2020 21:02
@scalvert scalvert changed the title feat(plugin-ember-octane): Create plugin-ember-octane Create plugin-ember-octane Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkup-task Changes scoped to a specific task/set of tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants