Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring generators can generate into a specific path #515

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Ensuring generators can generate into a specific path #515

merged 6 commits into from
Jun 24, 2020

Conversation

scalvert
Copy link
Contributor

@scalvert scalvert commented Jun 23, 2020 •
edited
Loading

Fixes generators to correctly generate in a specified path. Changes the path arg to a flag.

checkup generate config --path ./lib

TODO:

  • Add tests

@scalvert scalvert added bug Something isn't working requires-doc-update labels Jun 23, 2020
@scalvert scalvert changed the title Ensuring generators can generate into a specific path WIP: Ensuring generators can generate into a specific path Jun 23, 2020
@scalvert scalvert changed the title WIP: Ensuring generators can generate into a specific path Ensuring generators can generate into a specific path Jun 23, 2020
@scalvert scalvert merged commit 5563bbf into master Jun 24, 2020
@scalvert scalvert deleted the fix-generators2 branch June 24, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carakessler carakessler carakessler left review comments

Assignees

@carakessler carakessler

Labels
bug Something isn't working requires-doc-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scalvert @carakessler