Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing TaskType in favor of group #498

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Removing TaskType in favor of group #498

merged 3 commits into from
Jun 16, 2020

Conversation

scalvert
Copy link
Contributor

@scalvert scalvert commented Jun 15, 2020

This removes the TaskType enum and type prop in TaskClassification in favor of a group string prop. This provides more flexibility to specify both the category (primary grouping mechanism) and group (secondary grouping mechanism).

Example: under the linting category, you could specify an eslint group comprised of 3 tasks and a template lint group comprised of 2 tasks. The sorting would be as follows:

linting

eslint task 1
eslint task 2
eslint task 3

template lint task 1
template lint task 2 

TODO

  • Add sorting secondarily by group (after category)

@scalvert scalvert requested a review from carakessler June 15, 2020 23:16
@carakessler carakessler merged commit 2e99e84 into master Jun 16, 2020
@carakessler carakessler deleted the type-to-group branch June 16, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants