Adding Actions to checkup #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
requested changes
Jun 12, 2020
packages/checkup-plugin-ember-octane/src/results/octane-migration-status-task-result.ts
Outdated
Show resolved
Hide resolved
packages/checkup-plugin-javascript/__tests__/eslint-disable-task-test.ts
Outdated
Show resolved
Hide resolved
scalvert
requested changes
Jun 13, 2020
#475 for more info. In this PR, I added the infrastructure to add action items to tasks, and render them in the output. There will be followup PRs adding availableActions to more tasks, and leveraging this feature further, but to start I added it to the eslint-disable task
Decoupling ActionConfig from TaskConfig
scalvert
requested changes
Jun 15, 2020
packages/checkup-plugin-javascript/__tests__/eslint-disable-task-test.ts
Outdated
Show resolved
Hide resolved
scalvert
reviewed
Jun 16, 2020
scalvert
requested changes
Jun 16, 2020
scalvert
approved these changes
Jun 16, 2020
|
Just going to merge this for now. We can iterate on tidying anything that's rough later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#475 for more info.
In this PR, I added the infrastructure to add action items to tasks, and render them in the output. There will be followup PRs adding availableActions
to more tasks, and leveraging this feature further, but to start I added it to the eslint-disable task