Creating FilePathsArray class that extends array and offers filtering functionality #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
requested changes
Jun 1, 2020
scalvert
changed the title
scalvert
approved these changes
Jun 1, 2020
…tionality Many of the tasks were taking the paths string[] from TaskContext and using micromatch to filter by globs. Now, the paths object in TaskContext is of type FilePaths which extends array and adds function filterByGlob, to make it easier for task authors to filter the file paths array. This obscures the implementation detail of using micromatch to authors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the tasks were taking the paths string[] from TaskContext and using micromatch to filter by globs. Now, the paths object in TaskContext is of type FilePaths which extends array and adds function filterByGlob, to make it easier for task authors to filter the file paths array. This obscures the implementation detail of using micromatch to authors.