Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize flags #424

Merged
merged 1 commit into from
May 19, 2020
Merged

Standardize flags #424

merged 1 commit into from
May 19, 2020

Conversation

scalvert
Copy link
Contributor

This is primarily a flags cleanup PR. I've done the following:

  1. Removed the silent option (for now, it wasn't working anyway!)
  2. Removed the force option (wasn't used)
  3. Renamed reporter to format
  4. Renamed reportOutputDir to outputFile, and made it accept a file path instead

The main change is the last one, and I've added the ability to output both HTML and JSON. You can now do the following:

  • checkup -f <format> - will output to stdout
  • checkup -f <format> -o '{default}.<format>' - will output using the default name format (example: checkup-report-2020-05-18-14_56_19.`)
  • checkup -f <format> -o my-file.<format> - will output using the specified name to the cwd
  • checkup -f <format> -o /absolute/my-file.<format> - will output using the absolute path

@scalvert scalvert requested review from carakessler and rwjblue May 18, 2020 23:05
@scalvert scalvert added the internal Internal infrastructure work label May 18, 2020
@scalvert scalvert added this to the MVP milestone May 18, 2020
@carakessler carakessler merged commit 3da2f3a into master May 19, 2020
@carakessler carakessler deleted the standard-output-dir branch May 19, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal infrastructure work requires-doc-update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants