Implementing numerical-card #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carakessler
force-pushed
the
numerical
branch
2 times, most recently
from
c1a6059 to
7d95d55
Compare
scalvert
requested changes
Apr 8, 2020
packages/cli/__tests__/report-components/numerical-card-test.ts
Outdated
Show resolved
Hide resolved
|
The screenshot looks promising, but I really can't tell what all these fake values represent. This is why I'm not a fan of faker; the data doesn't really make sense in context, and the only value that's provided is that you get to exercise the worst case scenarios for visual rendering. Would it be possible to update the screenshot with more realistic values? |
carakessler
force-pushed
the
numerical
branch
2 times, most recently
from
006790d to
da18ab2
Compare
scalvert
requested changes
Apr 10, 2020
packages/cli/__tests__/report-components/numerical-card-test.ts
Outdated
Show resolved
Hide resolved
Implemented numerical-card and wrote tests. Added in support to render partials for tests as well, which will be used by other partials
scalvert
reviewed
Apr 10, 2020
scalvert
reviewed
Apr 10, 2020
Co-Authored-By: Steve Calvert <scalvert@linkedin.com>
Co-Authored-By: Steve Calvert <scalvert@linkedin.com>
scalvert
requested changes
Apr 10, 2020
Implemented numerical-card and wrote tests. Added in support to render partials for tests as well, which will be used by other partials
scalvert
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented numerical-card and wrote tests. Added in support to render partials for tests as well, which will be used by other partials. Screenshot below shows numerical card in the grid populated with fake data.