Adding task error output to indicate tasks ran, but with errors #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
changed the title
zhanwang626
approved these changes
Jun 21, 2022
|
@zhanwang626 I agree. There's a number of components that need tests, and I'd like to add those all in a separate PR. I can add the |
|
@zhanwang626 I added a quick sanity check test for |
zhanwang626
approved these changes
Jun 21, 2022
scalvert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds output to indicate whether the task ran with non-fatal errors or not.
This was a regression when we swapped over from standard output writing to Ink. This change includes some updates/changes to that error output.
Example output: