Issue #11166: Fix existing cases of getFileContents() usage in Javado… #18881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssefalaa7
force-pushed
the
issue-11166-Fix-existing-cases-of-getFileContents-usage
branch
2 times, most recently
from
a29bb38 to
ac34928
Compare
Youssefalaa7
force-pushed
the
issue-11166-Fix-existing-cases-of-getFileContents-usage
branch
6 times, most recently
from
ab9813f to
292fe40
Compare
… in JavadocMethodCheck
Youssefalaa7
force-pushed
the
issue-11166-Fix-existing-cases-of-getFileContents-usage
branch
from
292fe40 to
c72df05
Compare
Contributor
Author
|
Github, generate report for JavadocMethod/all-examples-in-one |
Contributor
|
Report for JavadocMethod/all-examples-in-one: |
Contributor
Author
|
@romani the differences found should be 0 right? so hear it means i made wrong logic? |
romani
requested changes
Feb 11, 2026
| " public void method() {}"))); | ||
| fileContents.reportBlockComment(1, 0, 1, 13); | ||
| fileContents.reportBlockComment(2, 3, 2, 20); | ||
| final TextBlock javadoc = fileContents.getJavadocBefore(3); |
Member
There was a problem hiding this comment.
All tests should be by verifyxXxxxx method usage.
No pure unit testing.
Contributor
Author
There was a problem hiding this comment.
All tests in this file are unit tests there are no tests using verifyxXxxxx because thiss is testing the method getJavadocBefore that we removed its usage from JavadocMethodCheck.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11166: Fix existing cases of getFileContents() usage in JavadocMethodCheck
removed the calling of getFileContents and parsed the javadoc comment and changed it to text
and then converted the javadoc comment AST node to a TextBlock