Skip to content

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Sep 10, 2025

#17487

enabler for:

driven by:

Changes have been made to src/test/java/com/puppycrawl/tools/checkstyle/IndentationTrailingCommentsVerticalAlignmentTest.java by:
[INFO]     org.openrewrite.java.migrate.Java8toJava11
[INFO]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[INFO]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[INFO]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17-pathOf branch from 04c8643 to d17be39 Compare September 10, 2025 18:24
@Pankraz76 Pankraz76 marked this pull request as ready for review September 10, 2025 18:26
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17-pathOf branch from d17be39 to 705d771 Compare September 10, 2025 19:41
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17-pathOf branch from 416989e to 16b495b Compare September 11, 2025 19:17
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17-pathOf branch from 16b495b to 0ae347a Compare September 11, 2025 19:19
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17-pathOf branch from 0ae347a to 71d42dc Compare September 11, 2025 19:28
Copy link
Member

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

---
type: specs.openrewrite.org/v1beta/recipe
name: CheckstyleAutoFix
name: org.checkstyle.CheckstyleAutoFix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not related to this PR's issue, but I agree to keep it. Common practice I saw in rewrite.yml configs is to use fully qualified names to avoid potential conflicts when multiple active recipes are present.

@rdiachenko rdiachenko assigned romani and unassigned rdiachenko Sep 11, 2025
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, train is moving forward, train is heavy but we moving it

@romani romani merged commit 204f8e2 into checkstyle:master Sep 12, 2025
120 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants