-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Issue #17487: Introduce Rewrite:Java8toJava11
#17772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #17487: Introduce Rewrite:Java8toJava11
#17772
Conversation
04c8643 to
d17be39
Compare
d17be39 to
705d771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok for me.
9 min in execution https://app.circleci.com/pipelines/github/checkstyle/checkstyle/36556/workflows/3aa130df-6cd6-49eb-a0dc-e1b292b270c3/jobs/1069343
416989e to
16b495b
Compare
16b495b to
0ae347a
Compare
0ae347a to
71d42dc
Compare
rdiachenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| --- | ||
| type: specs.openrewrite.org/v1beta/recipe | ||
| name: CheckstyleAutoFix | ||
| name: org.checkstyle.CheckstyleAutoFix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not related to this PR's issue, but I agree to keep it. Common practice I saw in rewrite.yml configs is to use fully qualified names to avoid potential conflicts when multiple active recipes are present.
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, train is moving forward, train is heavy but we moving it
#17487
enabler for:
Rewrite:UpgradeToJava17#17730driven by: