Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #15967: fix yield fails indentation in switch with forceStrictCondition #16131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #15967: fix yield fails indentation in switch with forceStrictCondition #16131

wants to merge 1 commit into from
+118 −0

Conversation

mohitsatr
Copy link
Contributor

@mohitsatr mohitsatr commented Jan 8, 2025 •
edited
Loading

fixes #15967

@mohitsatr
Copy link
Contributor Author

Github, generate report for Indentation/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/3e7d5725ca45c29dd648e9f327c747f0d6dbc36f_2025035608/reports/diff/index.html

@mohitsatr
Copy link
Contributor Author

Github, generate report for Indentation/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cd71ef5dfae68317192a2f1da929c90d6f3e3abf_2025040603/reports/diff/index.html

@mohitsatr
Copy link
Contributor Author

Github, generate report for Indentation/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/62e609c8b48bfd3d5400bafd16a408dd8e2abc8b_2025142828/reports/diff/index.html

@mohitsatr
Copy link
Contributor Author

Github, generate report for Indentation/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/d0132876528a78777f0d3aa54f84c1b694b769b9_2025041449/reports/diff/index.html

@mohitsatr
Copy link
Contributor Author

Github, generate report for Indentation/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/64352f4a73da6a3f31eac0af6439dcf578a8561c_2025030346/reports/diff/index.html

@mohitsatr
Copy link
Contributor Author

Github, generate report for Indentation/Example2

@github-actions GitHub Actions
Copy link
Contributor

Report for Indentation/Example2:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/64352f4a73da6a3f31eac0af6439dcf578a8561c_2025035508/reports/diff/index.html

@mohitsatr
Copy link
Contributor Author

mohitsatr commented Jan 13, 2025 •
edited
Loading

@romani please check out regression report #16131 (comment)

basically it resolves the original problem for which issue is raised. there is just one false positive case
i have been playing with it and looks like it requires more than a simple code change as there are more diffs in subsequent reports. I think we should raise separate issue for that case. what do you think?

other report : #16131 (comment)
#16131 (comment)
problem arises when switch appears as a condition in if

if (switch(today) {
   . .. .
    }
)

ps: please ignore diff reports which are not linked in this comment

@mohitsatr
Copy link
Contributor Author

Github, generate report for Indentation/all-examples-in-one

@github-actions GitHub Actions
Copy link
Contributor

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/df5c74582934d04e5e56708089edba2e8d571e00_2025034305/reports/diff/index.html

romani
romani requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

...ycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationYieldForceStrict.java Outdated Show resolved Hide resolved
romani
romani approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge !!

thanks a lot !

@nrmancuso
Copy link
Member

@romani please reply to comment at #16131 (comment)

@mohitsatr please rebase on the latest master branch

@nrmancuso nrmancuso assigned romani and unassigned nrmancuso Jan 25, 2025
@romani
Copy link
Member

romani commented Jan 25, 2025

yes, lets create separate issue on this case, we can improve lateron on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yield fails Indentation check in switch expressions
3 participants
@mohitsatr @nrmancuso @romani