-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Github workflow that provide links to test-configs but reuse contribution repo for report generation #15235
Conversation
Please make CI green meanwhile we do review. |
Share link to PR where you did this testing |
Please confirm by test that only single workflow will trigger on trigger phrase. Either existing workflow or new. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items
|
200cea1
to
c5fb32c
Compare
https://github.com/checkstyle-gsoc/checkstyle/actions/runs/9914040056/job/27392335628 Here, is the workflow running. This is the link to the PR: checkstyle-gsoc#1 where I am testing new changes. |
here is diff - https://www.diffchecker.com/Oj9yiOZe/ with original action |
@relentless-pursuit , please review all CIs and fix them all. Only one failure is expected is for nonaproved issue. |
c5fb32c
to
a0fd4d1
Compare
yes, trying to fix them |
Pull latest code from main repository, here are commands https://checkstyle.org/beginning_development.html#Starting_Development , there is video on how to do this |
a20753b
to
0bb3769
Compare
I know that. I was just focused on the lin github issue. Now, i have rebased. I guess other jobs related to checkstyle won't fail. |
6191a42
to
af4ca24
Compare
https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/50203364/job/6err460sotf7qxm1#L115 Before push please do on your local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
existing workflow is complicated and fragile, we won't be reusing this.
Dismissing this as I will never approve this copy-paste, and the PR will stand indefinitely
Link of the issue section which doesn't trigger the workflow after writing the command intended to trigger the workflow. So, far the workflow is trigger only if it is a PR comment. |
3a9d9af
to
4103691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge.
All other improvements for implementation will done in next PRs.
This works and others can start to use it they see it convenient.
Merge of this will also unblock testing of generated configs one by one
#15235 (comment) |
User friendly messages are out of scope for now, this is just basic implementation that is already usable. Very fragile on user typos. There will be a way more improvements but I highly recommend to do this in separate PRs. |
@rnveach , please review, we need to merge base version to start extensive testing and improvement on inner parts. Example of usage in PR: checkstyle-gsoc#7 |
Another example. |
Then point to issue where it is documented current issues and what will be fixed in the future. I expected to see documentation of issues, especially around things I mentioned above. |
I placed few more links to PR description to mention that it is far from final version, there are a lot of rooms to improve. Test-configs issue tracker contains more issues that describe what will happen this month. |
4103691
to
7c61ecb
Compare
…t-configs but reuse contribution repo for report generation
15aca68
to
f5f795e
Compare
You may merge this if you really want to. I will be abstaining from approving. |
#15380 here is reminder to document, assignment to me |
Resolves: #15234
doc how to use: https://github.com/checkstyle/test-configs/tree/main/AbbreviationAsWordInName/Example1#example1-configs
for later:
checkstyle/test-configs#131
checkstyle/test-configs#139
checkstyle/test-configs#140
example of usage: checkstyle-gsoc#7
checkstyle-gsoc#16
or bunch of any other PR: https://github.com/checkstyle-gsoc/checkstyle/pulls
also done:
The code changes also included the rocket symbol not working. This has been fixed and tested.
Link to the PR testing: checkstyle-gsoc#7
also done:
We need one PR at a time.
As you can see with changes in workflow to option c, i can only run the latest. Others will be cancelled in the same PR.
Link to PR: https://github.com/checkstyle-gsoc/pull/11