Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Github workflow that provide links to test-configs but reuse contribution repo for report generation #15235

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

relentless-pursuit
Copy link

@relentless-pursuit relentless-pursuit commented Jul 11, 2024

Resolves: #15234

doc how to use: https://github.com/checkstyle/test-configs/tree/main/AbbreviationAsWordInName/Example1#example1-configs

for later:

checkstyle/test-configs#131
checkstyle/test-configs#139
checkstyle/test-configs#140

example of usage: checkstyle-gsoc#7
checkstyle-gsoc#16
or bunch of any other PR: https://github.com/checkstyle-gsoc/checkstyle/pulls

also done:
The code changes also included the rocket symbol not working. This has been fixed and tested.
image
Link to the PR testing: checkstyle-gsoc#7

also done:
We need one PR at a time.
Screenshot 2024-07-24 at 1 10 24 AM

As you can see with changes in workflow to option c, i can only run the latest. Others will be cancelled in the same PR.

image Link to PR: https://github.com/checkstyle-gsoc/pull/11

@relentless-pursuit
Copy link
Author

image

@romani
Copy link
Member

romani commented Jul 12, 2024

Please make CI green meanwhile we do review.

@romani
Copy link
Member

romani commented Jul 12, 2024

Share link to PR where you did this testing

@romani
Copy link
Member

romani commented Jul 12, 2024

Please confirm by test that only single workflow will trigger on trigger phrase. Either existing workflow or new.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

.github/workflows/regression-report.yml Outdated Show resolved Hide resolved
.github/workflows/regression-report.yml Outdated Show resolved Hide resolved
@relentless-pursuit
Copy link
Author

Share link to PR where you did this testing

checkstyle-gsoc#2

checkstyle-gsoc#2 (comment)
checkstyle-gsoc#2 (comment)

@relentless-pursuit
Copy link
Author

https://github.com/checkstyle-gsoc/checkstyle/actions/runs/9914040056/job/27392335628

Here, is the workflow running.

This is the link to the PR: checkstyle-gsoc#1 where I am testing new changes.

@checkstyle checkstyle deleted a comment from relentless-pursuit Jul 12, 2024
@romani
Copy link
Member

romani commented Jul 12, 2024

here is diff - https://www.diffchecker.com/Oj9yiOZe/ with original action

@romani
Copy link
Member

romani commented Jul 12, 2024

@relentless-pursuit , please review all CIs and fix them all. Only one failure is expected is for nonaproved issue.

@relentless-pursuit
Copy link
Author

@relentless-pursuit , please review all CIs and fix them all. Only one failure is expected is for nonaproved issue.

yes, trying to fix them

@romani
Copy link
Member

romani commented Jul 12, 2024

Pull latest code from main repository, here are commands https://checkstyle.org/beginning_development.html#Starting_Development , there is video on how to do this

@relentless-pursuit relentless-pursuit force-pushed the newWorkflow branch 2 times, most recently from a20753b to 0bb3769 Compare July 12, 2024 23:27
@relentless-pursuit
Copy link
Author

Pull latest code from main repository, here are commands https://checkstyle.org/beginning_development.html#Starting_Development , there is video on how to do this

I know that. I was just focused on the lin github issue. Now, i have rebased. I guess other jobs related to checkstyle won't fail.

@relentless-pursuit relentless-pursuit force-pushed the newWorkflow branch 2 times, most recently from 6191a42 to af4ca24 Compare July 12, 2024 23:55
@romani
Copy link
Member

romani commented Jul 13, 2024

https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/50203364/job/6err460sotf7qxm1#L115

Before push please do on your local mvn verify it will save you a lot of time, as feedback on quality will be quicker.

Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing workflow is complicated and fragile, we won't be reusing this.

@nrmancuso nrmancuso removed the blocked label Jul 13, 2024
@nrmancuso nrmancuso assigned romani and unassigned nrmancuso Jul 13, 2024
@nrmancuso nrmancuso dismissed their stale review July 13, 2024 15:12

Dismissing this as I will never approve this copy-paste, and the PR will stand indefinitely

@relentless-pursuit
Copy link
Author

checkstyle-gsoc#4

Link of the issue section which doesn't trigger the workflow after writing the command intended to trigger the workflow. So, far the workflow is trigger only if it is a PR comment.

@relentless-pursuit relentless-pursuit force-pushed the newWorkflow branch 3 times, most recently from 3a9d9af to 4103691 Compare July 17, 2024 00:30
@relentless-pursuit
Copy link
Author

image image

the above screenshots show that making a comment on the issue doesn't trigger any workflow. it is only reserved for PR comment.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.

All other improvements for implementation will done in next PRs.
This works and others can start to use it they see it convenient.

Merge of this will also unblock testing of generated configs one by one

@romani romani requested a review from rnveach July 17, 2024 00:50
@romani romani assigned rnveach and unassigned romani Jul 17, 2024
@rnveach
Copy link
Member

rnveach commented Jul 18, 2024

#15235 (comment)
So we get a random error message if user mis-spells check or example? What if user uses \ instead of /? What if only check if given? Is the workflow sensitive to white space or new line after?

@romani
Copy link
Member

romani commented Jul 18, 2024

User friendly messages are out of scope for now, this is just basic implementation that is already usable. Very fragile on user typos.

There will be a way more improvements but I highly recommend to do this in separate PRs.

@romani
Copy link
Member

romani commented Jul 19, 2024

@rnveach , please review, we need to merge base version to start extensive testing and improvement on inner parts.

Example of usage in PR: checkstyle-gsoc#7

@romani
Copy link
Member

romani commented Jul 21, 2024

Another example.
At #15334 , instead of placing links to PR.
@mahfouz72 can just do Github, generate report for NeedBraces/all-examples-in-one

@rnveach
Copy link
Member

rnveach commented Jul 22, 2024

There will be a way more improvements but I highly recommend to do this in separate PRs.

Then point to issue where it is documented current issues and what will be fixed in the future.

I expected to see documentation of issues, especially around things I mentioned above.

@romani
Copy link
Member

romani commented Jul 22, 2024

I placed few more links to PR description to mention that it is far from final version, there are a lot of rooms to improve.

Test-configs issue tracker contains more issues that describe what will happen this month.
August issues are not yet created, plan in gdoc

…t-configs but reuse contribution repo for report generation
@rnveach
Copy link
Member

rnveach commented Jul 26, 2024

@romani
#15234 (comment)

You may merge this if you really want to. I will be abstaining from approving.

@romani
Copy link
Member

romani commented Jul 26, 2024

#15380 here is reminder to document, assignment to me

@romani romani merged commit d2a87e4 into checkstyle:master Jul 26, 2024
111 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Github workflow that provide links to test-configs but reuse contribution repo for report generation
4 participants