-
Notifications
You must be signed in to change notification settings - Fork 2
chore : 환경 세팅 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdds a new Next.js 16 TypeScript app scaffold named Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant PR as Pull Request
participant GH as GitHub Actions (preview)
participant Vercel as Vercel
participant Bot as PR Commenter
PR->>GH: open/update PR targeting main
GH->>GH: checkout, install deps, build artifacts
GH->>Vercel: deploy prebuilt artifacts (using Vercel CLI + secrets)
Vercel-->>GH: returns preview URL
GH->>Bot: post comment with preview URL on PR
note right of GH `#e6f4ea`: preview workflow finishes
sequenceDiagram
autonumber
participant Push as Push to main
participant GH as GitHub Actions (deploy)
participant Build as build.sh
participant Repo as Destination repo action
Push->>GH: trigger Deploy workflow
GH->>Build: run build.sh (create output)
Build-->>GH: output directory available
GH->>Repo: push output to other repository (uses action + secrets)
note right of GH `#f7eef8`: deploy workflow completes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
checkmo/eslint.config.mjs (1)
5-16: Consider using standard ESLint v9 flat config format.The current configuration uses
defineConfig()wrapper andglobalIgnores()function, which don't match the standard ESLint v9 flat config API. In ESLint v9, the flat config format typically exports a plain array withignoresas a property in config objects.If the current imports fail, apply this diff to use the standard ESLint v9 flat config format:
-import { defineConfig, globalIgnores } from "eslint/config"; import nextVitals from "eslint-config-next/core-web-vitals"; import nextTs from "eslint-config-next/typescript"; -const eslintConfig = defineConfig([ +export default [ ...nextVitals, ...nextTs, - // Override default ignores of eslint-config-next. - globalIgnores([ + { + // Override default ignores of eslint-config-next. + ignores: [ - // Default ignores of eslint-config-next: - ".next/**", - "out/**", - "build/**", - "next-env.d.ts", - ]), -]); - -export default eslintConfig; + ".next/**", + "out/**", + "build/**", + "next-env.d.ts", + ], + }, +];Note: Verify that the import paths
eslint-config-next/core-web-vitalsandeslint-config-next/typescriptare correct for v16. The standard import might be different.checkmo/README.md (1)
1-36: Consider customizing the README for your project.The README currently contains the standard Next.js boilerplate. Consider adding:
- Project-specific description and purpose
- Team-specific setup instructions
- Architecture overview
- Contribution guidelines
Also note that line 19 references
app/page.tsx, but your project structure usessrc/app/page.tsx.checkmo/src/app/layout.tsx (1)
15-18: Update placeholder metadata for production.The metadata currently uses default values from
create-next-app. Consider updating the title and description to reflect your actual application name and purpose in a follow-up task.For example:
export const metadata: Metadata = { - title: "Create Next App", - description: "Generated by create next app", + title: "Checkmo", + description: "Your application description here", };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
checkmo/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlcheckmo/public/file.svgis excluded by!**/*.svgcheckmo/public/globe.svgis excluded by!**/*.svgcheckmo/public/next.svgis excluded by!**/*.svgcheckmo/public/vercel.svgis excluded by!**/*.svgcheckmo/public/window.svgis excluded by!**/*.svgcheckmo/src/app/favicon.icois excluded by!**/*.ico
📒 Files selected for processing (10)
checkmo/.gitignore(1 hunks)checkmo/README.md(1 hunks)checkmo/eslint.config.mjs(1 hunks)checkmo/next.config.ts(1 hunks)checkmo/package.json(1 hunks)checkmo/postcss.config.mjs(1 hunks)checkmo/src/app/globals.css(1 hunks)checkmo/src/app/layout.tsx(1 hunks)checkmo/src/app/page.tsx(1 hunks)checkmo/tsconfig.json(1 hunks)
🔇 Additional comments (8)
checkmo/eslint.config.mjs (1)
1-1: The import is correct. ESLint v9 flat config exports defineConfig and globalIgnores from the "eslint/config" entrypoint, and eslint-config-next v16 uses the same pattern. No changes needed.checkmo/src/app/page.tsx (2)
3-65: Component structure looks good!The page component is well-structured with proper use of Next.js Image component, Tailwind CSS v4 utilities, and responsive design patterns. The dark mode variants and semantic HTML are appropriate.
7-14: The referenced SVG files exist in the repository.The static assets (
next.svgandvercel.svg) are present incheckmo/public/and correctly accessible via the/next.svgand/vercel.svgpaths used in the component. No 404 errors will occur. The code is working as intended.Likely an incorrect or invalid review comment.
checkmo/package.json (2)
17-17: React Compiler configuration verified as correct.The setup is properly configured for Next.js 16 with React Compiler:
babel-plugin-react-compiler1.0.0 is included as a devDependencyreactCompiler: trueis explicitly set innext.config.ts- No Babel configuration files are present, which is correct—Next.js 16 automatically handles React Compiler integration without requiring manual Babel configuration
No changes needed.
9-9: Update the lint script to specify file patterns (ESLint configuration file already exists).The lint script is incomplete and needs file patterns. However, the recommendation should use the ESLint CLI directly—Next.js 16 removed the built-in next lint command and the next.config.js eslint option; Next recommends using the ESLint CLI (flat config) and the packaged eslint-config-next.
Update the script to:
- "lint": "eslint" + "lint": "eslint . --ext .js,.jsx,.ts,.tsx"Note: The ESLint configuration file (
eslint.config.mjs) already exists in the repository and is properly configured with Next.js presets.Likely an incorrect or invalid review comment.
checkmo/src/app/layout.tsx (3)
1-14: LGTM! Font optimization setup is correct.The imports and font configuration follow Next.js best practices. The use of
next/font/googlewith CSS variables ensures optimal font loading and rendering performance.
26-26: Verify language attribute for target audience.The
langattribute is set to"en", but the PR description is in Korean, suggesting this application may serve Korean users. Consider whetherlang="ko"or a dynamic language detection mechanism would be more appropriate for your use case.
20-34: LGTM! Layout structure is correct.The RootLayout component follows Next.js app router conventions correctly, with proper TypeScript typing, font variable application, and children rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
checkmo/tailwind.config.js (1)
2-2: Remove or correct the redundant content path.The content array includes
'./app/**/*.{js,ts,jsx,tsx}', but according to the project structure, your app directory is nested undersrc/(e.g.,src/app/layout.tsx). This path is already covered by'./src/**/*.{js,ts,jsx,tsx}', making the./app/**pattern redundant and potentially confusing.Apply this diff to remove the redundant path:
- content: ['./src/**/*.{js,ts,jsx,tsx}', './app/**/*.{js,ts,jsx,tsx}'], + content: ['./src/**/*.{js,ts,jsx,tsx}'],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
checkmo/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
checkmo/package.json(1 hunks)checkmo/tailwind.config.js(1 hunks)
🔇 Additional comments (3)
checkmo/package.json (3)
11-29: Dependencies are free from known security vulnerabilities.The specified versions are secure: Next.js 16.0.1, React 19.2.0, and Tailwind CSS ^4 have no matching known security advisories. Older versions have CVEs, but your current versions are not affected.
17-17: Tailwind CSS v4 is confirmed stable and production-ready.Tailwind CSS v4 was released as a stable release on January 22, 2025, with follow-up releases including v4.1 on April 3, 2025. The versions specified in package.json (
@tailwindcss/cli: ^4.1.17,@tailwindcss/postcss: ^4, andtailwindcss: ^4) are appropriate for a production codebase and do not present stability concerns.
12-12: Next.js 16.0.1 is confirmed stable and current.Next.js 16 was released as a stable major release on October 21, 2025, and version 16.0.1 was published as the latest 16.x patch on October 28, 2025. The package specification is valid for production use.
💡 To Reviewers
기초 환경 세팅을 진행합니다.
🔥 작업 내용 (가능한 구체적으로 작성해 주세요)
🤔 추후 작업 예정
📸 작업 결과 (스크린샷)
🔗 관련 이슈
Resolved #1
Summary by CodeRabbit
New Features
Style
Documentation
Chores