Skip to content

Conversation

nickykln
Copy link
Contributor

@nickykln nickykln commented May 22, 2025

Description

This pull request moves all sensitive configuration data (Firebase, Sentry, keys, etc.) into a private, non-versioned file environments.private.json, and updates the AWS Terraform infrastructure to dynamically load these secrets.
It also improves ECS deployment robustness (healthcheck management, etc.).

Changes

  • Moved sensitive configuration to environments.private.json
  • Loads environment variables via jsondecode(file(...)) in Terraform
  • Added a .gitignore to protect sensitive files
  • Increased ALB healthcheck timeouts to avoid interruptions during long migrations
  • Fixed environment variables for CORS (MARBLE_APP_URL and MARBLE_BACKOFFICE_HOST now use the full URL)
  • Updated the README to document the new organization

Additional Information

  • Sensitive files in config/ are excluded from version control.

To test:

  • Ensure Terraform deployment runs without errors
  • Check that the application starts and endpoints are accessible

Screenshots

Not applicable for this configuration/infra PR.

Checklist

  • Tests passed
  • Manual QA done
  • Documentation updated

@Pascal-Delange
Copy link
Contributor

Hi @nickykln ,
Sorry I missed this PR 3 weeks ago. I'll check it out tomorrow.

@Pascal-Delange
Copy link
Contributor

Hi @nickykln !
Thanks for the contribution.
Can I please send you our contributor license agreement before we merge this ? What email address can I send it to ?
Best,
Pascao

…vérification de santé à 60 secondes, ajoute des variables d'environnement pour Convoy dans la définition de tâche ECS, et augmente le stockage maximal alloué pour RDS à 3000 Go.
@nickykln
Copy link
Contributor Author

nickykln commented Aug 6, 2025

Hi @Pascal-Delange
You can send it to nicolas@pixpay.fr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants