Fix 3c tests failing when check-all is run. #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 3C developers added a separate test target for 3c called check-3c. This sped up testing 3c. However, the clang build also adds a test target for each clang-based tool. This results in two targets in check-all that both run 3c tests. This in turn leads to 2 builds of the 3C tests suite being run in parallel when check-all is run in parallel. This causes things such as file-level access conflicts, which causes some 3C tests to fail. This changes removes the separate test target for 3c, so that 3c tests follow the same approaches used for tests for other clang-based tools in the repo.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3C developers added a separate test target for 3c called check-3c. This sped up testing 3c. However, the clang build also adds a test target for each clang-based tool. This results in two targets in check-all that both run 3c tests. This in turn can lead to 2 builds of the 3C tests suite being run in parallel when check-all is run in parallel. This causes things such as file-level access conflicts, which causes some 3C tests to fail.
This change removes the separate test target for 3c, so that 3c tests follow the same approaches used for tests for other clang-based tools in the repo.