Fix for Issue #1195 #1196
Merged
Fix for Issue #1195 #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtarditi, Can you take a look into this? |
dtarditi
pushed a commit
that referenced
this pull request
Sep 28, 2024
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the error -->
typename llvm::cast_retty<X, Y*>::ret_type llvm::cast(Y*) [with X = clang::Expr; Y = const clang::Stmt; typename llvm::cast_retty<X, Y*>::ret_type = const clang::Expr*]: Assertion `isa(Val) && "cast() argument of incompatible type!"' failed.
Description of Fix -->
I have a fix I believe involves the least changes, so as to disturb the main line as little as possible.
Regression CheckedC Testing -->
Testing Time: 14.53s
Unsupported: 3
Passed : 96
Regression Clang Testing -->
Failed Tests (3):
Clang :: 3C/json_formatting.c
Clang :: 3C/json_formatting_backslash.c
Clang :: 3C/multiple_tu.c
Testing Time: 2095.93s
Unsupported : 75
Passed : 27663
Expectedly Failed: 34
Failed : 3
Please note that the above 3 tests are also failing for me on "untouched" main-branch.