Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter out init-ssh-agent from Che Code's Devfile task lists #445

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Oct 25, 2024

What does this PR do?

Filter out init-ssh-agent from Che Code's Devfile task lists

What issues does this PR fix?

eclipse-che/che#23144

How to test this PR?

  1. Start a workspace: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/eclipse-che/che-dashboard?che-editor=che-incubator/che-code/insiders&editor-image=quay.io/che-incubator-pull-requests/che-code:pr-445-amd64
  2. Terminal => Run task => devfile
  3. Check that init-ssh-agent-command is absent in the devfile list

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link

github-actions bot commented Oct 25, 2024

Click here to review and test in web IDE: Contribute

Copy link

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before
image

after
image

Thanks @RomanNikitenko for fixing this!

@RomanNikitenko RomanNikitenko merged commit c4e688f into main Oct 25, 2024
8 checks passed
@RomanNikitenko RomanNikitenko deleted the filter-devfile-commands branch October 25, 2024 13:08
@devstudio-release
Copy link

Build 3.18 :: code_3.x/1488: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7964: FAILURE

code : 3.x :: Failed in 65415798 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.18 :: code_3.x/1489: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/8018: FAILURE

code : 3.x ::
; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants