Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'New Terminal (Select a Container)' action to Terminal and terminal's context menus #193

Merged
merged 2 commits into from
Apr 4, 2023
Merged

feat: Add 'New Terminal (Select a Container)' action to Terminal and terminal's context menus #193

merged 2 commits into from
Apr 4, 2023

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Mar 27, 2023 •
edited
Loading

What does this PR do?

  • command Create New Terminal to DevWorkspace Container is renamed to Create New Terminal (Select a Container)
  • command is added to the Terminal menu
  • command is added to the terminal's context menu

What issues does this PR fix?

eclipse-che/che#22086

How to test this PR?

  • create a workspace using this reference. It uses current PR image to create an editor.
  • check that command Create New Terminal to DevWorkspace Container has new title Create New Terminal (Select a Container)
  • check that the command is available for running from Terminal menu
  • check that the command is available for running from terminal's context menu
newCheTerminal.mp4

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-193-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-193-dev-amd64

1 similar comment
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-193-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-193-dev-amd64

@RomanNikitenko
chore: Rename 'Create New Terminal to DevWorkspace Container' command
41ffb1c 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko changed the title chore: Rename 'Create New Terminal to DevWorkspace Container' command feat: Add 'New Terminal (Select a Container)' action to Terminal and terminal's context menus Apr 3, 2023
@RomanNikitenko
feat: Add 'New Terminal (Select a Container)' action to Terminal and …
710a43b 
…terminal's context menu

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-193-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-193-dev-amd64

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-193-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-193-dev-amd64

@RomanNikitenko RomanNikitenko marked this pull request as ready for review April 3, 2023 12:53
@RomanNikitenko RomanNikitenko requested a review from l0rd April 3, 2023 13:08
l0rd
l0rd approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked like a charm 👍

@RomanNikitenko RomanNikitenko merged commit 0774654 into che-incubator:main Apr 4, 2023
@RomanNikitenko RomanNikitenko deleted the newTerminalInContainer branch April 4, 2023 11:08
@devstudio-release
Copy link

Build 3.6 :: code_3.x/517: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2879: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: get-sources-rhpkg-container-build_3.x/2696: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: push-latest-container-to-quay_3.x/2048: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: get-sources-rhpkg-container-build_3.x/2696: SUCCESS

code : 3.x :: Build 51794609 : quay.io/devspaces/code-rhel8:3.6-46
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/2048 triggered

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2672: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: code_3.x/517: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2879 triggered

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/1066: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2881: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: get-sources-rhpkg-container-build_3.x/2698: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: push-latest-container-to-quay_3.x/2050: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1197: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1197: SUCCESS

3.6
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.6-151
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.19-4
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-470799-440885-s390x
  + quay.io/devspaces/iib:3.6-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.6-v4.12-470798-440880-s390x
  + quay.io/devspaces/iib:3.6-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.6-v4.11-470797-440871-s390x
  + quay.io/devspaces/iib:3.6-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.6-v4.10-470796-440866-s390x
  + quay.io/devspaces/iib:3.6-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-470799-440885-ppc64le
  + quay.io/devspaces/iib:3.6-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-470798-440880-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-470797-440871-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-470796-440866-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-470799-440885-x86_64
  + quay.io/devspaces/iib:3.6-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-470798-440880-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-470797-440871-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-470796-440866-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

@devstudio-release devstudio-release mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@l0rd l0rd l0rd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RomanNikitenko @devstudio-release @l0rd @azatsarynnyy @vitaliy-guliy