Skip to content

Commit

Permalink
tacacs: Make expert info appear in dialog
Browse files Browse the repository at this point in the history
The if (tree) construct prevents the expert info from
appearing when there's a null tree (i.e., Expert Info
Dialog with no filter.) It's not really necessary here
(or in most dissectors currently.)

Related to #19325
  • Loading branch information
johnthacker committed Sep 16, 2023
1 parent 108217f commit a8f7cf2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions epan/dissectors/packet-tacacs.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ dissect_tacacs(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _
col_add_str(pinfo->cinfo, COL_INFO,
val_to_str(type, tacacs_type_vals, "Unknown (0x%02x)"));

if (tree)
/* if (tree) */
{
ti = proto_tree_add_protocol_format(tree, proto_tacacs,
tvb, 0, -1, version==0?"TACACS":"XTACACS");
Expand Down Expand Up @@ -902,7 +902,7 @@ dissect_tacplus_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, voi
request ? "Q" : "R",
val_to_str(tvb_get_guint8(tvb,1), tacplus_type_vals, "Unknown (0x%02x)"));

if (tree)
/* if (tree) */
{
ti = proto_tree_add_item(tree, proto_tacplus, tvb, 0, -1, ENC_NA);

Expand Down

0 comments on commit a8f7cf2

Please sign in to comment.