Merge pull request #1 from danehans/provider-refactor-fix-gw-delete

Adds Gateway Deletion Support to Controller
chauhanshubham · Dec 2, 2022 · b910b06 · b910b06
2 parents 17f5447 + d7feaf2
commit b910b06
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/internal/provider/kubernetes/controller.go b/internal/provider/kubernetes/controller.go
@@ -442,6 +442,9 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, request reconcile.
 			return reconcile.Result{}, err
 		}
 
+		// Store the resource tree to trigger a delete operation.
+		r.resources.GatewayAPIResources.Store(acceptedGC.Name, resourceTree)
+
 		// No further processing is required as there are no Gateways for this GatewayClass
 		return reconcile.Result{}, nil
 	}

diff --git a/internal/provider/kubernetes/kubernetes_test.go b/internal/provider/kubernetes/kubernetes_test.go
@@ -162,11 +162,11 @@ func testGatewayClassAcceptedStatus(ctx context.Context, t *testing.T, provider
 		return false
 	}, defaultWait, defaultTick)
 
-	// Since there are no Gateways present for the GatewayClass, we store nothing
-	// in the resource map.
+	// Even though no gateways exist, the controller loads the empty resource map
+	// to support gateway deletions.
 	require.Eventually(t, func() bool {
 		_, ok := resources.GatewayAPIResources.Load(gc.Name)
-		return !ok
+		return ok
 	}, defaultWait, defaultTick)
 }