Skip to content

feat: generate openrpc definitions #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2023
Merged

feat: generate openrpc definitions #25

merged 1 commit into from
May 21, 2023

Conversation

Frando
Copy link
Collaborator

@Frando Frando commented Nov 25, 2022

@Frando
Copy link
Collaborator Author

Frando commented Jan 24, 2023

I think this is basically good to go, but I want to add a feature flag for it still to not force the schemars dependency if not needed

@link2xt link2xt force-pushed the openrpc branch 2 times, most recently from 3a17d13 to b481713 Compare May 17, 2023 19:48
@link2xt
Copy link
Contributor

link2xt commented May 17, 2023

I have created a follow-up PR to turn schemas into references: #51.

There I modified examples/axum/openrpc.json with an example of how to reference schema objects. You can also look at the default example at https://playground.open-rpc.org/ for an example of using references internal to OpenRPC document.

@link2xt
Copy link
Contributor

link2xt commented May 20, 2023

Now references are used in this PR, definitions are generated into #/components/schemas/....

@link2xt link2xt requested a review from Simon-Laux May 20, 2023 19:35
@link2xt link2xt force-pushed the openrpc branch 2 times, most recently from 6cc4fdc to e010dd5 Compare May 21, 2023 15:34
@link2xt
Copy link
Contributor

link2xt commented May 21, 2023

I think this is basically good to go, but I want to add a feature flag for it still to not force the schemars dependency if not needed

I added openrpc feature.

@link2xt link2xt marked this pull request as ready for review May 21, 2023 15:45
Co-Authored-By: Simon Laux <mobile.info@simonlaux.de>
Co-Authored-By: link2xt <link2xt@testrun.org>
@link2xt link2xt merged commit 4dfa912 into main May 21, 2023
@link2xt link2xt deleted the openrpc branch May 21, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants