Conversation
1b75b8c to
30225f2
Compare
| # | ||
|
|
||
| # use dkim-milter instead of OpenDKIM | ||
| dkim_milter = false |
There was a problem hiding this comment.
In the end we don't need an option, it is fine to remove everything OpenDKIM-related. But existing users need a way to migrate. Ideally old key should just be reused, so no DNS changes are needed.
There was a problem hiding this comment.
One downside of this I see is that we will leave "opendkim" in names (e.g. selector) which may be a bit confusing - but I guess it's fine.
| packages=["rustc", "cargo", "openssl"], | ||
| ) | ||
|
|
||
| cargo.packages( |
There was a problem hiding this comment.
Instead of building on the server, the binaries are better built on CI similar to how chatmail-turn is doing this: chatmail/dkim-milter#1
30225f2 to
f2eb636
Compare
f2eb636 to
e72e169
Compare
e72e169 to
511af0c
Compare
|
Setting aside the binary deployment deployment strategy, looks good to me. Having worked on #530 I wonder if dkim-milter can do the stripping of validated DKIM-Signatures as well? I see the default config does strip the Authentication-Results already. |
511af0c to
60e549d
Compare
60e549d to
504b50c
Compare
504b50c to
27ec9fd
Compare
27ec9fd to
88ba086
Compare
|
On Mon, Jan 12, 2026 at 06:34 -0800, Jagoda Estera Ślązak wrote:
j-g00da left a comment (chatmail/relay#798)
I'm currently using self hosted binaries with custom patches (chatmail/dkim-milter#3) to allow communication over unix domain socket.
What I think is mostly left to do in order to complete this is to port lua scripts. Since dkim-milter doesn't support custom scripts, I will probably just implement it directly on our fork.
Sounds good to directly implement the lua scripts' logic, maybe in some extra module.
|
b15bb7b to
4ba9027
Compare
4ba9027 to
8c8f28b
Compare
8c8f28b to
3ace933
Compare
|
This currently works, CI fails due to unrelated issues. Few notes:
|
Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
3ace933 to
1726ee7
Compare
We are now using dkim-milter instead of OpenDKIM. Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
No description provided.