feat: Check whether GCC is installed in initenv.sh#608
feat: Check whether GCC is installed in initenv.sh#608missytake merged 2 commits intochatmail:mainfrom
Conversation
- The Python modules installed by initenv.sh require a compiler to build. - Revised initenv.sh to check whether build-essential is installed before proceeding, if the system is based on Debian or Ubuntu.
|
Because |
missytake
left a comment
There was a problem hiding this comment.
Hm, are you sure you need to install build-essential? Why doesn't our CI need it? https://github.com/chatmail/relay/actions/runs/16828106233/job/47669201565?pr=610
It ran fine without build-essential so far.
|
Okay, that makes this a CI-breaking change, so I guess I need to go the route of identifying the more specific set of packages that are needed. It's probably |
e1851bb to
6486184
Compare
|
It appears that the For the current set of Python dependencies, without GCC, the build process fails when building the crypt-r package. According to the error message, on my system the exact command it tries to run is 'x86_64-linux-gnu-gcc', but rather than depend on this variant specifically, the script checks for the generic 'gcc' command, so as to avoid coupling the check to an architecture or operating system. Similar problems arise if we attempt to check for packages by name; the compiler binary is provided by 'gcc-11', but the symlinks that provide the unversioned commands (as used by the Python build) come from a package named 'gcc'. Trying to be too precise in what we check for could lead to unnecessary failures in some environments, or become a maintenance challenge in the future. For that reason, this change simply attempts to run 'gcc' and uses that as a probably-sufficient proxy for having what the Python package install will need. |
- Before proceeding with installation of Python dependencies, check whether the 'gcc' command is available by running it with the --version argument. If it is not available, print a helpful message and exit. - For the current set of Python dependencies, without GCC, the build process fails when building the crypt-r package. According to the error message, on my system the exact command it tries to run is 'x86_64-linux-gnu-gcc', but rather than depend on this variant specifically, the script checks for the generic 'gcc' command, so as to avoid coupling the check to an architecture or operating system. Similar problems arise if we attempt to check for packages by name; the compiler binary is provided by 'gcc-11', but the symlinks that provide the unversioned commands (as used by the Python build) come from a package named 'gcc'. Trying to be too precise in what we check for could lead to unnecessary failures in some environments, or become a maintenance challenge in the future. For that reason, this change simply attempts to run 'gcc' and uses that as a probably-sufficient proxy for having what the Python package install will need.
6486184 to
ffa5609
Compare
Uh oh!
There was an error while loading. Please reload this page.